Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚰️ zb: remove unused arg0namespace from match rule #428

Merged
merged 2 commits into from
Aug 4, 2023
Merged

⚰️ zb: remove unused arg0namespace from match rule #428

merged 2 commits into from
Aug 4, 2023

Conversation

MaxVerevkin
Copy link
Contributor

It was replaced by arg0ns and is now unused.

zeenix
zeenix approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @elmarco broke the Windows CI so either he'll fix that or I'll revert his commits soon.

zbus/src/match_rule/builder.rs Outdated Show resolved Hide resolved
@MaxVerevkin
⚰️ zb: remove unused arg0namespace from match rule
176e500 
It was replaced by arg0ns and is now unused.
@MaxVerevkin
⚰️ remove imports of Try{From,Into}
9e1f6ea 
Try{From,Into} are in the prelude since 2021 edition.
zeenix
zeenix approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zeenix zeenix merged commit ad3a373 into dbus2:main Aug 4, 2023
7 checks passed
@MaxVerevkin MaxVerevkin deleted the apibreak branch August 4, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeenix zeenix zeenix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxVerevkin @zeenix